Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/2810#issuecomment-59400293
Yup, LGTM. And as a general rule for the future, avoid pattern matching on
Some and None. In most cases you should instead use a map, flatMap or foreach
over the Option. Even, as in this instance, when you can't do that, matching
on Some and None isn't good Scala style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
