Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/20010#discussion_r158852830
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -469,12 +488,21 @@ class TypeCoercionSuite extends AnalysisTest {
ArrayType(ArrayType(IntegerType), containsNull = false),
ArrayType(ArrayType(LongType), containsNull = false),
Some(ArrayType(ArrayType(LongType), containsNull = false)))
+ widenTestWithStringPromotion(
+ StructType(StructField("a", ArrayType(LongType)) :: Nil),
+ StructType(StructField("a", ArrayType(StringType)) :: Nil),
+ Some(StructType(StructField("a", ArrayType(StringType)) :: Nil)))
+
// Without string promotion
widenTestWithoutStringPromotion(IntegerType, StringType, None)
widenTestWithoutStringPromotion(StringType, TimestampType, None)
widenTestWithoutStringPromotion(ArrayType(LongType),
ArrayType(StringType), None)
widenTestWithoutStringPromotion(ArrayType(StringType),
ArrayType(TimestampType), None)
+ widenTestWithoutStringPromotion(
+ StructType(StructField("a", ArrayType(LongType)) :: Nil),
+ StructType(StructField("a", ArrayType(StringType)) :: Nil),
+ None)
--- End diff --
I've grouped non-string promotion tests, and added tests for arrays, maps,
and then structures nested in those types or having fields of those types,
https://github.com/apache/spark/pull/20010/files#diff-01ecdd038c5c2f53f38118912210fef8R563
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
