Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20082#discussion_r158855520
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
    @@ -42,6 +42,7 @@ import org.apache.spark.util._
      */
     private[spark] class TaskContextImpl(
         val stageId: Int,
    +    val stageAttemptId: Int,
    --- End diff --
    
    nit: add `override`. Since you are touching this file, could you also add 
`override` to `stageId` and `partitionId`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to