Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20111#discussion_r159022777
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/FeatureHasherSuite.scala ---
    @@ -17,26 +17,23 @@
     
     package org.apache.spark.ml.feature
     
    -import org.apache.spark.SparkFunSuite
     import org.apache.spark.ml.attribute.AttributeGroup
     import org.apache.spark.ml.linalg.{Vector, Vectors}
     import org.apache.spark.ml.param.ParamsSuite
    -import org.apache.spark.ml.util.DefaultReadWriteTest
    +import org.apache.spark.ml.util.{DefaultReadWriteTest, MLTest}
     import org.apache.spark.ml.util.TestingUtils._
    -import org.apache.spark.mllib.util.MLlibTestSparkContext
    +import org.apache.spark.sql.Row
     import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
     import org.apache.spark.sql.functions.col
     import org.apache.spark.sql.types._
     
    -class FeatureHasherSuite extends SparkFunSuite
    -  with MLlibTestSparkContext
    -  with DefaultReadWriteTest {
    +class FeatureHasherSuite extends MLTest with DefaultReadWriteTest {
     
       import testImplicits._
     
       import HashingTFSuite.murmur3FeatureIdx
     
    -  implicit private val vectorEncoder = ExpressionEncoder[Vector]()
    +  implicit private val vectorEncoder: ExpressionEncoder[Vector] = 
ExpressionEncoder[Vector]()
    --- End diff --
    
    scala style


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to