Github user advancedxy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20082#discussion_r159038326
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
    @@ -150,6 +150,13 @@ abstract class TaskContext extends Serializable {
        */
       def stageId(): Int
     
    +  /**
    +   * An ID that is unique to the stage attempt that this task belongs to. 
It represents how many
    +   * times the stage has been attempted. The first stage attempt will be 
assigned stageAttemptId = 0
    +   * , and subsequent attempts will increasing stageAttemptId one by one.
    +   */
    +  def stageAttemptId(): Int
    --- End diff --
    
    I have no objection for either ‘id’ nor ‘number’, they are both 
reasonable. 
    
    I am on train now。 If no other input, I can rename it to 
‘stageAttemptNumber’ since you insisted.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to