Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19977#discussion_r159048727
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ---
    @@ -653,7 +660,11 @@ object CombineConcats extends Rule[LogicalPlan] {
       }
     
       def apply(plan: LogicalPlan): LogicalPlan = 
plan.transformExpressionsDown {
    -    case concat: Concat if concat.children.exists(_.isInstanceOf[Concat]) 
=>
    +    case concat: Concat if concat.children.exists {
    --- End diff --
    
    Create a dedicated helper function for the if condition?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to