Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20116#discussion_r159112727 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java --- @@ -87,19 +79,7 @@ public void remove() { } /** - * Resets the batch for writing. - */ - public void reset() { - for (int i = 0; i < numCols(); ++i) { - if (columns[i] instanceof WritableColumnVector) { - ((WritableColumnVector) columns[i]).reset(); - } - } - this.numRows = 0; --- End diff -- This can result an incorrect `numRows`. May it be a potential error?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org