Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/20082#discussion_r159227953
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -79,6 +79,7 @@ private[spark] abstract class Task[T](
SparkEnv.get.blockManager.registerTask(taskAttemptId)
context = new TaskContextImpl(
stageId,
+ stageAttemptId, // stageAttemptId and stageAttemptNumber are
semantically equal
--- End diff --
The modification may not be too much (100+ occurrences in 20+ files),
however it may break eventLog's JsonProtocol backward compatibility(not sure)..
@squito you may have more knowledge on this since you introduced
`stageAttemptId`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
