Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20097#discussion_r159365598
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamSourceV2.scala
---
@@ -32,16 +32,17 @@ import
org.apache.spark.sql.sources.v2.DataSourceV2Options
import org.apache.spark.sql.sources.v2.reader._
import org.apache.spark.sql.sources.v2.streaming.reader.{MicroBatchReader,
Offset}
import org.apache.spark.sql.types.{LongType, StructField, StructType,
TimestampType}
-import org.apache.spark.util.SystemClock
+import org.apache.spark.util.{ManualClock, SystemClock}
class RateStreamV2Reader(options: DataSourceV2Options)
extends MicroBatchReader {
implicit val defaultFormats: DefaultFormats = DefaultFormats
- val clock = new SystemClock
+ val clock = if (options.get("useManualClock").orElse("false").toBoolean)
new ManualClock
--- End diff --
also mention that manualClock is only used for testing so that someone
looking at the source does not confuse this to be a publicly visible feature.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
