Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/20119#discussion_r159370941
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -133,7 +132,7 @@ public Object convertToNetty() throws IOException {
if (conf.lazyFileDescriptor()) {
return new DefaultFileRegion(file, offset, length);
} else {
- FileChannel fileChannel = FileChannel.open(file.toPath(),
StandardOpenOption.READ);
+ FileChannel fileChannel = new FileInputStream(file).getChannel();
--- End diff --
@jerryshao I think this is the only line that may reduce the memory
pressure for external shuffle service. Right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
