Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20148#discussion_r159588468
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/MountSecretsBootstrap.scala
---
@@ -28,20 +28,26 @@ private[spark] class
MountSecretsBootstrap(secretNamesToMountPaths: Map[String,
*
* @param pod the pod into which the secret volumes are being added.
* @param container the container into which the secret volumes are
being mounted.
+ * @param addNewVolumes whether to add new secret volumes for the
secrets.
--- End diff --
Agreed. I didn't separate it out because we will touch this code as part of
refactoring the steps code anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
