Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20024#discussion_r159627615
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
 ---
    @@ -0,0 +1,52 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions.codegen;
    +
    +import java.nio.charset.StandardCharsets;
    +
    +import org.apache.spark.unsafe.types.UTF8String;
    +
    +/**
    + * A helper class to write `UTF8String`, `String`, and `byte[]` data into 
an internal buffer
    + * and get a final concatenated string.
    + */
    +public class UTF8StringBuilder {
    +
    +  private StringBuilder buffer;
    --- End diff --
    
    We should use the byte[] backed implementation. At the end we need a 
`UTF8String`, by wrapping `StringBuilder` we still have the unnecessary 
`String` -> `UTF8String` -> `String` conversion.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to