Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19992#discussion_r159812291
  
    --- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala 
---
    @@ -2022,12 +1947,7 @@ private[spark] object JsonProtocolSuite extends 
Assertions {
           |      "Port": 300
           |    },
           |    "Block ID": "rdd_0_0",
    -      |    "Storage Level": {
    --- End diff --
    
    yup, I completely agree that off heap is not respected in the json format.  
can you file a bug?  I think its still relevant even after this goes in, for 
custom levels


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to