Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r159955747
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,22 @@
package org.apache.spark.sql.test
-trait SharedSQLContext extends SQLTestUtils with SharedSparkSession
+trait SharedSQLContext extends SQLTestUtils with SharedSparkSession {
+
+ /**
+ * Auto thread audit is turned off here intentionally and done manually.
--- End diff --
I'm still a little not convinced that this is needed.
I still think that any reported leaks here are caused by bugs in the test
suites and not because of this. The code you have here is basically the same
thing as `SparkFunSuite`.
For example, if a suite extending this does not call `super.beforeAll()`
but calls `super.afterAll()`, won't you get false positives in the output?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
