Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20164#discussion_r160020496
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -170,21 +170,24 @@ final class OneVsRestModel private[ml] (
newDataset.persist(StorageLevel.MEMORY_AND_DISK)
}
+ // temporary column to store intermediate raw prediction
+ val tmpRawPredictionColName = "mbc$tmpraw" + UUID.randomUUID().toString
--- End diff --
in other ml cases we are slightly more descriptive with the prefix text
https://github.com/apache/spark/blob/576c43fb4226e4efa12189b41c3bc862019862c6/mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala#L1050
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
