Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19943#discussion_r160077716
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -386,6 +386,16 @@ object SQLConf {
         .checkValues(Set("hive", "native"))
         .createWithDefault("native")
     
    +  val ORC_VECTORIZED_READER_ENABLED = 
buildConf("spark.sql.orc.enableVectorizedReader")
    +    .doc("Enables vectorized orc decoding.")
    +    .booleanConf
    +    .createWithDefault(true)
    +
    +  val ORC_VECTORIZED_JAVA_READER_ENABLED = 
buildConf("spark.sql.orc.enableVectorizedJavaReader")
    --- End diff --
    
    Yes. It does, but we need to choose the best one for both performance and 
maintenance perspective.
    
    Until now, according to the performance result, java implementations 
doesn't outperform scala version. I'll remove at the last minute to make it 
sure.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to