Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2824#discussion_r19034247
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -272,20 +272,38 @@ private[spark] object Utils extends Logging {
/** Copy all data from an InputStream to an OutputStream */
def copyStream(in: InputStream,
out: OutputStream,
- closeStreams: Boolean = false): Long =
+ closeStreams: Boolean = false,
+ transferToEnabled: Boolean = true): Long =
--- End diff --
Should we change this default to `false`? This would help us to guard
against cases in which new code uses `copyStream` on File[Input|Output]Streams
but the programmer forgot to read the configuration option. I guess my concern
is that I want to ensure that if `spark.file.transferTo` is false, then we are
guaranteed to _never_ use the `transferTo` path in this function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
