Github user henrify commented on the issue:
https://github.com/apache/spark/pull/19943
@dongjoon-hyun Great, so it is bit faster with putX, but not that much.
I'm still concerned how well the big nextBatch() method gets optimized; JVM
can bail out of optimizing complex methods. If you don't want to do full
refactor of splitting every for loop to small individual methods, you could try
extracting for loop of just one data type and benchmark if it makes any
difference. Also, have you checked how inlining goes with
XX:+UnlockDiagnosticVMOptions and -XX:+PrintInlining ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
