Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160255634
--- Diff: python/pyspark/ml/image.py ---
@@ -201,8 +243,9 @@ def readImages(self, path, recursive=False,
numPartitions=-1,
.. versionadded:: 2.3.0
"""
- spark = SparkSession.builder.getOrCreate()
- image_schema = spark._jvm.org.apache.spark.ml.image.ImageSchema
+ ctx = SparkContext.getOrCreate()
--- End diff --
minor comment: the change before was only two lines whereas this is 3 lines
- I think the previous change was better, what is the advantage of the new code?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
