Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20179#discussion_r160313408
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala 
---
    @@ -376,18 +374,13 @@ private[netty] class NettyRpcEnv(
     
         def setError(e: Throwable): Unit = {
           error = e
    -      source.close()
         }
     
         override def read(dst: ByteBuffer): Int = {
    --- End diff --
    
    so the caller of `read` would close the source channel?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to