Github user imatiach-msft commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20168#discussion_r160316719
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala 
---
    @@ -143,12 +174,12 @@ object ImageSchema {
     
           val height = img.getHeight
           val width = img.getWidth
    -      val (nChannels, mode) = if (isGray) {
    -        (1, ocvTypes("CV_8UC1"))
    +      val (nChannels, mode: Int) = if (isGray) {
    --- End diff --
    
    ah, sorry, I see, I was confused by the description, if we aren't 
supporting float images for reading that makes sense now


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to