Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19943#discussion_r160360721
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
 ---
    @@ -118,6 +118,13 @@ class OrcFileFormat
         }
       }
     
    +  override def supportBatch(sparkSession: SparkSession, schema: 
StructType): Boolean = {
    +    val conf = sparkSession.sessionState.conf
    +    conf.orcVectorizedReaderEnabled && conf.wholeStageEnabled &&
    +      schema.length <= conf.wholeStageMaxNumFields &&
    +      schema.forall(_.dataType.isInstanceOf[AtomicType])
    +  }
    +
    --- End diff --
    
    Do we need to implement `vectorTypes` as `ParquetFileFormat`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to