Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20199#discussion_r160396117
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -58,7 +58,7 @@ class VersionsSuite extends SparkFunSuite with Logging {
*/
protected def withTempDir(f: File => Unit): Unit = {
val dir = Utils.createTempDir().getCanonicalFile
- try f(dir) finally Utils.deleteRecursively(dir)
+ f(dir)
--- End diff --
Hm, actually, shall we just skip the failing tests for now
(`assume(Utils.isWindows)`)? Given what we talked, only few tests are failed in
some few conditions when Hive version is 0.12?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
