Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20153#discussion_r160472490
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala 
---
    @@ -137,4 +147,25 @@ private[sql] trait ColumnarBatchScan extends 
CodegenSupport {
          """.stripMargin
       }
     
    +  private def produceRows(ctx: CodegenContext, input: String): String = {
    +    val numOutputRows = metricTerm(ctx, "numOutputRows")
    +    val row = ctx.freshName("row")
    +
    +    ctx.INPUT_ROW = row
    +    ctx.currentVars = null
    +    // Always provide `outputVars`, so that the framework can help us 
build unsafe row if the input
    +    // row is not unsafe row, i.e. `needsUnsafeRowConversion` is true.
    +    val outputVars = output.zipWithIndex.map{ case (a, i) =>
    --- End diff --
    
    nit: `map {`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to