Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19876#discussion_r160461560
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
    @@ -85,12 +87,55 @@ private[util] sealed trait BaseReadWrite {
       protected final def sc: SparkContext = sparkSession.sparkContext
     }
     
    +/**
    + * ML export formats for should implement this trait so that users can 
specify a shortname rather
    + * than the fully qualified class name of the exporter.
    + *
    + * A new instance of this class will be instantiated each time a DDL call 
is made.
    --- End diff --
    
    Was this supposed to be retained from the `DataSourceRegister`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to