Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20222#discussion_r160740904
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -34,6 +34,10 @@ import com.typesafe.tools.mima.core.ProblemFilters._
      */
     object MimaExcludes {
     
    +  // Exclude rules for 2.4.x
    --- End diff --
    
    This reminds me that we should probably bump `previousSparkVersion` in 
`MimaBuild.scala` to be 2.2.0: 
https://github.com/apache/spark/blame/f340b6b3066033d40b7e163fd5fb68e9820adfb1/project/MimaBuild.scala#L91.
 I think this should happen for both master and branch-2.3.
    
    See #15061 for an example of a similar change when 2.1.x was being prepared 
(it looks like we missed this step for 2.2.0). We may also need to un-exclude 
any new subprojects / artifacts that were added in 2.2.0 since they now need to 
be backwards-compatibility-tested for 2.3.x.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to