Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20217#discussion_r160858810
  
    --- Diff: python/pyspark/sql/catalog.py ---
    @@ -255,26 +255,67 @@ def registerFunction(self, name, f, 
returnType=StringType()):
             >>> _ = spark.udf.register("stringLengthInt", len, IntegerType())
             >>> spark.sql("SELECT stringLengthInt('test')").collect()
             [Row(stringLengthInt(test)=4)]
    +        """
    +
    +        # This is to check whether the input function is a wrapped/native 
UserDefinedFunction
    +        if hasattr(f, 'asNondeterministic'):
    --- End diff --
    
    It might be better to check `f` is (1) callable (2) not a UDF object


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to