Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2780#issuecomment-59603338
@chouqin Thanks for this PR! This method should be a real improvement. I
added some small comments inline.
My main concern right now is testing edge cases, like @manishamde
suggested. Could you try to add some please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
