Github user rednaxelafx commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20163#discussion_r161287717
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala
 ---
    @@ -144,6 +145,7 @@ object EvaluatePython {
         }
     
         case StringType => (obj: Any) => nullSafeConvert(obj) {
    +      case _: Calendar => null
           case _ => UTF8String.fromString(obj.toString)
    --- End diff --
    
    I was pounding on that yesterday, too... somehow I have this feeling that 
no matter which direction we take, there's no good answer to type mismatch 
situations.
    
    Let's say if we blacklist more types, should we document the list so that 
it's clear what will definitely NOT work?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to