Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20232#discussion_r161365548
  
    --- Diff: R/pkg/tests/fulltests/test_mllib_classification.R ---
    @@ -382,10 +382,10 @@ test_that("spark.mlp", {
       trainidxs <- base::sample(nrow(data), nrow(data) * 0.7)
       traindf <- as.DataFrame(data[trainidxs, ])
       testdf <- as.DataFrame(rbind(data[-trainidxs, ], c(0, "the other")))
    -  model <- spark.mlp(traindf, clicked ~ ., layers = c(1, 3))
    +  model <- spark.mlp(traindf, clicked ~ ., layers = c(1, 2))
    --- End diff --
    
    ok; I think perhaps we need to release-note this (like 
[this](http://spark.apache.org/docs/latest/sparkr.html#upgrading-to-sparkr-220))


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to