Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2845#discussion_r19064633
  
    --- Diff: dev/run-tests-jenkins ---
    @@ -92,12 +92,39 @@ function post_message () {
           echo " > api_response: ${api_response}" >&2
           echo " > data: ${data}" >&2
       fi
    -  
    +
       if [ "$curl_status" -eq 0 ] && [ "$http_code" -eq "201" ]; then
         echo " > Post successful."
       fi
     }
     
    +function send_archived_logs () {
    +  echo "Archiving unit tests logs..."
    +
    +  local log_files=$(find . -name "unit-tests.log")
    +
    +  if [ -z "$log_files" ]; then
    +    echo "> No log files found." >&2
    +  else
    +    local log_archive="unit-tests-logs.tar.gz"
    +    echo "$log_files" | xargs tar czf ${log_archive}
    --- End diff --
    
    Just wondering, will these appear in the tarfile under the full path (e.g. 
streaming/target/unit-tests.log)? That's ideal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to