Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20206#discussion_r161496715
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
 ---
    @@ -150,6 +152,10 @@ case class InsertIntoHadoopFsRelationCommand(
             }
           }
     
    +      val partitionSet = AttributeSet(partitionColumns)
    +      val dataColumns = query.output.filterNot(partitionSet.contains)
    --- End diff --
    
    We should use `outputColumns` instead of `query.output`, cc @gengliangwang 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to