Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20232#discussion_r161686126
--- Diff: docs/sparkr.md ---
@@ -663,3 +663,4 @@ You can inspect the search path in R with
[`search()`](https://stat.ethz.ch/R-ma
- The `stringsAsFactors` parameter was previously ignored with `collect`,
for example, in `collect(createDataFrame(iris), stringsAsFactors = TRUE))`. It
has been corrected.
- For `summary`, option for statistics to compute has been added. Its
output is changed from that from `describe`.
- A warning can be raised if versions of SparkR package and the Spark JVM
do not match.
+ - Previously, we don't check the validity of the size of the last layer
in `spark.mlp`. For example, if the training data only has two labels, a
`layers` param like `c(1, 3)` doesn't cause an error previously. Now it will
throw an exception.
--- End diff --
exception is ... unfortunately. generally we try to avoid it if we could;
you could change the call to `handledCallJMethod` but I think we should just
change the wording here a bit, to `doesn't cause an error previously, now it
does.`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
