Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r161816826
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -28,21 +28,14 @@
/**
* A column vector backed by Apache Arrow.
*/
-public final class ArrowColumnVector extends ColumnVector {
+public final class ArrowColumnVector implements ColumnVector {
private final ArrowVectorAccessor accessor;
private ArrowColumnVector[] childColumns;
- private void ensureAccessible(int index) {
--- End diff --
`ColumnVector` is a performance critical place, we don't need index
checking here, like other column vector implementations.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
