Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161834649
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
@Override
public synchronized void kill() {
- disconnect();
- if (childProc != null) {
- if (childProc.isAlive()) {
- childProc.destroyForcibly();
+ if (!isDisposed()) {
+ setState(State.KILLED);
--- End diff --
I changed this because the old disconnect code, at least, might change the
handle's state. It's easier to put this call first and not have to reason about
whether that will happen.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
