[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

[zsxwing]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19247#discussion_r161892343
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
 ---
    @@ -86,6 +86,18 @@ abstract class FileStreamSourceTest
         }
       }
     
    +  case class AddTextFileDataWithSpaceInFileName(content: String, src: 
File, tmp: File)
    --- End diff --
    
    I would suggest that adding a new parameter to AddTextFileData rather than 
introducing a new class, such as
    ```  case class AddTextFileData(content: String, src: File, tmp: File, 
tempFilePrefix: String = "text")
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org