Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20272#discussion_r161979319
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -328,7 +328,7 @@ object SparkSubmit extends CommandLineUtils with
Logging {
printErrorAndExit("Cluster deploy mode is not applicable to Spark
shells.")
case (_, CLUSTER) if isSqlShell(args.mainClass) =>
printErrorAndExit("Cluster deploy mode is not applicable to Spark
SQL shell.")
- case (_, CLUSTER) if isThriftServer(args.mainClass) =>
+ case (_, CLUSTER) if (clusterManager != KUBERNETES) &&
isThriftServer(args.mainClass) =>
printErrorAndExit("Cluster deploy mode is not applicable to Spark
Thrift server.")
--- End diff --
I haven't dug through but this might break if there has been any assumption
that thrift is not running in cluster mode?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
