Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2851#discussion_r19096569
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -30,7 +30,8 @@ import org.apache.spark.util.ActorLogReceive
     private[spark] case class Heartbeat(
         executorId: String,
         taskMetrics: Array[(Long, TaskMetrics)], // taskId -> TaskMetrics
    -    blockManagerId: BlockManagerId)
    +    blockManagerId: BlockManagerId,
    +    broadcastBlocks: Map[BlockId, Option[BlockStatus]])
    --- End diff --
    
    Would this send a BlockStatus for each broadcast variable on a heartbeat ? 
If we have hundreds or thousands of broadcast variables I wonder if the message 
size will become huge. Could we send deltas somehow ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to