Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20284#discussion_r162166090
--- Diff:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java
---
@@ -112,7 +114,8 @@ public void setup() throws Exception {
t.key = "key" + i;
t.id = "id" + i;
t.name = "name" + RND.nextInt(MAX_ENTRIES);
- t.num = RND.nextInt(MAX_ENTRIES);
+ // Force one item to have an integer value of zero to test the fix
for SPARK-23103.
+ t.num = (i != 0) ? (int) RND.nextLong() : 0;
--- End diff --
why the chang from `RND.nextInt(MAX_ENTRIES)`? this seems fine, just
seemed like you were more likely to stress collision on this index before.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
