Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/20275#discussion_r162292944
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -113,6 +113,13 @@ class VectorsSuite extends SparkFunSuite with Logging {
assert(vec.toArray === arr)
}
+ test("zero-length sparse vector") {
--- End diff --
While we're doing this we may as well also add a test to `intercept` the
exception for negative size (as per the other sparse vector construction
tests), for both `ml` and `mllib`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
