Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2576#issuecomment-59831796
Have addressed the comments and made changes as follows:
1 reuse code of TableReader for table scan
2 support all data types
3 move ```saveAsOrcFile``` and ```WriteToOrcFile``` to hive module since
ORC supported in ```HiveContext```
4 added more tests for orc meta data reader, data types supporting, empty
RDD and sql query over ORC etc..
5 code clean and adding orc support to docs
6 For writing ORC file, not reuse code of WriterContainer classes because
it's hard to make a proper ```FileSinkDesc``` there
@liancheng @yhuai @marmbrus @zhzhan @pwendell, any other comments here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
