Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2764#discussion_r19118592
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -319,10 +315,8 @@ case object ByteType extends IntegralType {
/** Matcher for any expressions that evaluate to [[FractionalType]]s */
object FractionalType {
- def unapply(a: Expression): Boolean = a match {
- case e: Expression if e.dataType.isInstanceOf[FractionalType] => true
- case _ => false
- }
+ def unapply[T <: Expression](a: T): Option[T] =
--- End diff --
Why are these type parameterized? Things seems to compile without this
added complexity. Extra refinement can be done regardless with nested pattern
matching.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
