Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20328#discussion_r162558096
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
    @@ -176,11 +176,16 @@ private[hive] class TestHiveSparkSession(
       }
     
       { // set the metastore temporary configuration
    -    val metastoreTempConf = 
HiveUtils.newTemporaryConfiguration(useInMemoryDerby = false) ++ Map(
    +    var metastoreTempConf = 
HiveUtils.newTemporaryConfiguration(useInMemoryDerby = false) ++ Map(
           ConfVars.METASTORE_INTEGER_JDO_PUSHDOWN.varname -> "true",
           // scratch directory used by Hive's metastore client
           ConfVars.SCRATCHDIR.varname -> 
TestHiveContext.makeScratchDir().toURI.toString,
           ConfVars.METASTORE_CLIENT_CONNECT_RETRY_DELAY.varname -> "1")
    --- End diff --
    
    nit:
    ```
    ... ++ existingSharedState.map { state =>
      val connKey = 
state.sparkContext.hadoopConfiguration.get(ConfVars.METASTORECONNECTURLKEY.varname)
      ConfVars.METASTORECONNECTURLKEY.varname -> connKey
    }.getOrElse(Map.empty)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to