Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20330#discussion_r162687023
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -65,10 +68,13 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
}.map { job =>
val jobId = job.jobId
val status = job.status
- val jobDescription =
store.lastStageAttempt(job.stageIds.max).description
- val displayJobDescription = jobDescription
- .map(UIUtils.makeDescription(_, "", plainText = true).text)
- .getOrElse("")
+ val (_, lastStageDescription) = lastStageNameAndDescription(store,
job)
+ val displayJobDescription =
+ if (lastStageDescription.isEmpty) {
--- End diff --
nit: I generally prefer the opposite check.
```
if (data is good)
do something with data
else
fallback to something else
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
