Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20277#discussion_r162747998 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java --- @@ -33,18 +33,6 @@ private final ArrowVectorAccessor accessor; private ArrowColumnVector[] childColumns; - private void ensureAccessible(int index) { - ensureAccessible(index, 1); - } - - private void ensureAccessible(int index, int count) { --- End diff -- I agree with this in non-debug version. Can we add assert of this check at each caller site for debugging? p.s. Sorry for slow reviews since I am on vacation this week.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org