Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20316#discussion_r162753323
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java ---
@@ -96,16 +90,6 @@ public void setNumRows(int numRows) {
*/
public int numRows() { return numRows; }
- /**
- * Returns the schema that makes up this batch.
- */
- public StructType schema() { return schema; }
-
- /**
- * Returns the max capacity (in number of rows) for this batch.
- */
- public int capacity() { return capacity; }
--- End diff --
I agree to remove these fields `schema` and `capacity` from `ColumnarBatch`.
Is it better to prepare APIs to get `schema` and `capacity` from a set of
`ColumnVector`s?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
