Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r163362834
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -113,7 +132,11 @@ private[feature] trait CountVectorizerParams extends
Params with HasInputCol wit
/** @group getParam */
def getBinary: Boolean = $(binary)
- setDefault(vocabSize -> (1 << 18), minDF -> 1.0, minTF -> 1.0, binary ->
false)
+ setDefault(vocabSize -> (1 << 18),
+ minDF -> 1.0,
+ maxDF -> Long.MaxValue,
--- End diff --
Let's hear also what other people think about this. Probably in practice
this is ok, but the other solution is cleaner IMHO.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
