Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20373#discussion_r163420474
  
    --- Diff: python/pyspark/cloudpickle.py ---
    @@ -522,17 +529,22 @@ def save_function_tuple(self, func):
             self.memoize(func)
     
             # save the rest of the func data needed by _fill_function
    -        save(f_globals)
    -        save(defaults)
    -        save(dct)
    -        save(func.__module__)
    -        save(closure_values)
    +        state = {
    +            'globals': f_globals,
    +            'defaults': defaults,
    +            'dict': dct,
    +            'module': func.__module__,
    +            'closure_values': closure_values,
    +        }
    +        if hasattr(func, '__qualname__'):
    +            state['qualname'] = func.__qualname__
    +        save(state)
    --- End diff --
    
    Preserve func.__qualname__ when defined 
https://github.com/cloudpipe/cloudpickle/commit/14b38a3ab5970d96cce1492c790494932285f845


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to