Github user henryr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20355#discussion_r163455727
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -78,4 +78,20 @@ class FileBasedDataSourceSuite extends QueryTest with
SharedSQLContext {
}
}
}
+
+ // Separate test case for text-based formats that support multiLine as
an option.
+ Seq("json", "csv", "text").foreach { format =>
--- End diff --
That sounds good - my main concern is to make sure that both
`multiLine=true` _and_ `multiLine=false` have coverage with a space in the
name, since they are such different paths. I'll keep the change that adds a
space to `nameWithSpecialChars`, but otherwise have the tests as you suggest -
let me know what you think of the next patch!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
