Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18931#discussion_r163518761
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -156,13 +156,94 @@ trait CodegenSupport extends SparkPlan {
ctx.INPUT_ROW = null
ctx.freshNamePrefix = parent.variablePrefix
val evaluated = evaluateRequiredVariables(output, inputVars,
parent.usedInputs)
+
+ // Under certain conditions, we can put the logic to consume the rows
of this operator into
+ // another function. So we can prevent a generated function too long
to be optimized by JIT.
+ // The conditions:
+ // 1. The config "SQLConf.DECOUPLE_OPERATOR_CONSUME_FUNCTIONS" is
enabled.
+ // 2. The parent uses all variables in output. we can't defer variable
evaluation when consume
+ // in another function.
+ // 3. The output variables are not empty. If it's empty, we don't
bother to do that.
+ // 4. We don't use row variable. The construction of row uses deferred
variable evaluation. We
+ // can't do it.
+ // 5. The number of output variables must less than maximum number of
parameters in Java method
+ // declaration.
+ val requireAllOutput = output.forall(parent.usedInputs.contains(_))
+ val consumeFunc =
+ if (SQLConf.get.decoupleOperatorConsumeFuncs && row == null &&
outputVars.nonEmpty &&
+ requireAllOutput && ctx.isValidParamLength(output)) {
+ constructDoConsumeFunction(ctx, inputVars)
+ } else {
+ parent.doConsume(ctx, inputVars, rowVar)
+ }
s"""
|${ctx.registerComment(s"CONSUME: ${parent.simpleString}")}
|$evaluated
- |${parent.doConsume(ctx, inputVars, rowVar)}
+ |$consumeFunc
+ """.stripMargin
+ }
+
+ /**
+ * To prevent concatenated function growing too long to be optimized by
JIT. We can separate the
+ * parent's `doConsume` codes of a `CodegenSupport` operator into a
function to call.
+ */
+ private def constructDoConsumeFunction(
+ ctx: CodegenContext,
+ inputVars: Seq[ExprCode]): String = {
+ val (callingParams, arguList, inputVarsInFunc) =
--- End diff --
I feel it's cleaner to return `paramNames, paramTypes, paramVars`, then we
can simply do
```
void $doConsume(paramTypes.zip(paramNames).map(i => i._1 + " " +
i._2).mkString(", "))
```
and
```
doConsumeFuncName(paramNames.mkString(", "))
```
inside `constructConsumeParameters` we can just create 3 mutable
collections and go through `variables` to fill these collections.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
